Skip to content

Conversation

lindseymoore
Copy link
Contributor

@lindseymoore lindseymoore commented Feb 18, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46744

Staging Links

  • data-modeling/documents
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 18, 2025

    Deploy Preview for docs-mongoid ready!

    Name Link
    🔨 Latest commit c871d47
    🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/67b63171e39b8700080c66a0
    😎 Deploy Preview https://deploy-preview-111--docs-mongoid.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Documents
    =========
    ===========================
    Ruby Document Object Module
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: Remove ruby
    A better option would be just Document Module or Document Model Class Module if it needs to be longer

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    How about "Include the Document Module in Your Object Class"? Want to try something more meaningful than a longer name

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Include the Document Module in Your Model?

    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    dont need to take another look but would in general recommend excluding Ruby from these titles

    @lindseymoore lindseymoore removed the request for review from rustagir February 19, 2025 19:31
    @lindseymoore lindseymoore merged commit cbef14b into mongodb:master Feb 19, 2025
    6 checks passed
    github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
    * DOCSP-46744 Too Short Titles: Document
    
    * edit
    
    * Rea edit
    
    (cherry picked from commit cbef14b)
    lindseymoore added a commit that referenced this pull request Feb 19, 2025
    * DOCSP-46744 Too Short Titles: Document
    
    * edit
    
    * Rea edit
    
    (cherry picked from commit cbef14b)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants