Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 30, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42735
Staging - https://deploy-preview-49--docs-mongoid.netlify.app/quick-start-sinatra/configure-mongodb/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit 7255928
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/66fc05706415a200092d49d4
😎 Deploy Preview https://deploy-preview-49--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but otherwise LGTM!

Comment on lines 23 to 26
We want to access the ``sample_restaurants`` database for this tutorial.
For example, if the connection string for your Atlas cluster is
``"mongodb+srv://user0:pass123@mongo0.example.com/"``, you can
specify the target database as shown in the following code:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be modified to just introduce the code example to avoid using "we" and to make it more closely mirror our other repos.

Suggested change
We want to access the ``sample_restaurants`` database for this tutorial.
For example, if the connection string for your Atlas cluster is
``"mongodb+srv://user0:pass123@mongo0.example.com/"``, you can
specify the target database as shown in the following code:
The following example specifies the ``sample_restaurants`` database in a connection string:


.. code-block:: none

mongodb+srv://user0:pass123@mongo0.example.com/sample_restaurants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mongodb+srv://user0:pass123@mongo0.example.com/sample_restaurants
mongodb+srv://<username>:<password>@mongo0.example.com/sample_restaurants

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the connection string as is an specify that its a sample

In your project, create the ``config`` directory, then create a
file in this directory called ``mongoid.yml``.

Paste the following configuration into the file, making sure to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Paste the following configuration into the file, making sure to
Paste the following configuration into the ``mongoid.yml`` file, making sure to

@rustagir rustagir merged commit 3f8e885 into mongodb:standardized Oct 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants