-
Notifications
You must be signed in to change notification settings - Fork 53
DOCSP-27149 guided quick start #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-27149 guided quick start #586
Conversation
ae06ed6
to
6b12a5f
Compare
wip small fixes add titles consolidate install, add buttons updates button format test hlist test cta alternate format fix button fix button convert to admonition change format troubleshooting reformat test wip edit text, add source constant capitalization restructure as quick start, separate connection string step fix toc edits edits remove cssclass add ref anchors and incorporate overview into quick start landing page add quick start to landing pages fix button link targets move driver install add title remove add an app wip WIP WIP WIP edits edits edits update figure reduce png size Revert "reduce png size" This reverts commit e89aed0. Revert "update figure" This reverts commit fe05da9. replace images fix images
4976a9c
to
9f908d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on making this! LGTM with just a couple non-blocking suggestions
|
||
Learn how to establish a connection to MongoDB Atlas and begin | ||
working with data in the :doc:`Quick Start </quick-start>` section. | ||
working with data in the step-by-step :doc:`Quick Start </quick-start>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but can we make this into a :ref: tag instead of a :doc: while we're making changes in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out! Since this PR isn't initially going to be backported, I think it might be better to leave alone and address somewhere else.
|
||
You can connect to your MongoDB deployment by providing a | ||
**connection URI**, also called a *connection string*, which | ||
instructs the driver how to connect to a MongoDB deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instructs the driver how to connect to a MongoDB deployment | |
instructs the driver on how to connect to a MongoDB deployment |
when applicable, and connection options. | ||
|
||
To connect to an instance or deployment not hosted on Atlas, see | ||
:ref:`Other Ways to Connect to MongoDB <node-other-ways-to-connect>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
Clicking on this link takes the user out of the tutorial completely, which also collapses it in the sidebar. I think this could be confusing to some and they may struggle to find their way back, or to find where they left off when they clicked it. Could we make this a link that opens in a new tab instead to mitigate those potential issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion! I think it might be ok this way for a couple reasons:
- The quick start is designed to achieve the goal of connecting via Atlas and requires the sample data sets to be loaded. If they are connecting to a deployment not hosted on Atlas, the rest of the directions won't really work without a fair amount of sleuthing.
- I'm not sure there's a way to specify a new tab with a
:ref:
or:doc:
directive; the external links will be styled differently, and could be confusing since they're generally used for external links only. Not sure if there's any written guidance, but I'm guessing they're treated as two different entities in the UX design based on the appended icon that follows external links.
* Guided Quick Start (cherry picked from commit 69c2e08)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-27149
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/DOCSP-27149-guided-quick-start/quick-start/
Self-Review Checklist