DOCSP-38042: CMAP Tracking Example #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmorisi
changed the title
norareidy
requested changes
May 29, 2024
| checkedOut = NaN; | ||
| } | ||
|
|
||
| // Increases count of active connection pool threads when connectionCheckedIn event is triggered |
There was a problem hiding this comment.
I: since this line calls the onCheckin() function, which decreases the checkedOut count, it seems a little misleading to say that this is increasing a count of active connection pool threads. Maybe you could reword to:
Suggested change
| // Increases count of active connection pool threads when connectionCheckedIn event is triggered | |
| // Decreases count of connections checked out of the pool when connectionCheckedIn event is triggered |
| // Increases count of active connection pool threads when connectionCheckedIn event is triggered | ||
| client.on('connectionCheckedIn', onCheckin); | ||
|
|
||
| // Decreases count of active connection pool threads when connectionCheckedOut event is triggered |
There was a problem hiding this comment.
I: similar comment as above
Suggested change
| // Decreases count of active connection pool threads when connectionCheckedOut event is triggered | |
| // Increases count of connections checked out of the pool when connectionCheckedOut event is triggered |
Comment on lines
44
to
46
| the behavior of your application's connection pool. The following example | ||
| demonstrates a function that uses connection pool monitoring events to return a count | ||
| of checked-out connections in the pool. |
There was a problem hiding this comment.
S: I think this sentence could be a little more concise, and it also can end with a colon. Maybe something like:
Suggested change
| the behavior of your application's connection pool. The following example | |
| demonstrates a function that uses connection pool monitoring events to return a count | |
| of checked-out connections in the pool. | |
| the behavior of your application's connection pool. The following example uses connection pool monitoring events to return a count | |
| of checked-out connections in the pool: |
| @@ -29,8 +29,8 @@ application run faster. | |||
| The following sections demonstrate how to record connection pool events in your | |||
| application or want to explore the information provided in these events. | |||
There was a problem hiding this comment.
S: out of scope for this ticket so not a necessary change, but this sentence is confusing. I think this wording makes more sense:
Suggested change
| application or want to explore the information provided in these events. | |
| application and explore the information provided in these events. |
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
mcmorisi
added a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1859354)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Paraphrased from requester: "The context here is to showcase a practical example of what CMAP monitoring could be used for – the existing "Event Subscription Example" shows how to subscribe, but not really why you'd bother in the first place."
Code sample provided by requester and tested by me (with comments added).
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-38042
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/node/DOCSP-38042-connection-tracking/fundamentals/monitoring/connection-monitoring/
Self-Review Checklist