Skip to content

Conversation

jordan-smith721
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-37539
Staging - https://preview-mongodbjordansmith721.gatsbyjs.io/pymongo/DOCSP-37539-change-streams/read/change-streams/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much lgtm save a few comments!

:language: python

When you update the collection, the change stream application prints the change
to the shell as it occurs. The change event printed to the shell resembles the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"printed to the shell" sounds confusing for a python user. I'd say something more like "the change event printed to the output".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified to just say "prints the change as it occurs"

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordan-smith721 jordan-smith721 merged commit 410e265 into mongodb:master May 9, 2024
@jordan-smith721 jordan-smith721 deleted the DOCSP-37539-change-streams branch May 9, 2024 15:12
jordan-smith721 added a commit that referenced this pull request May 9, 2024
(cherry picked from commit 410e265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants