-
Notifications
You must be signed in to change notification settings - Fork 62
(DOCSP-45749) Denests last phase 1 nested component for spark connector #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-spark-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sarahsimpers
added a commit
to sarahsimpers/docs-spark-connector
that referenced
this pull request
Dec 3, 2024
sarahsimpers
added a commit
that referenced
this pull request
Dec 3, 2024
sarahsimpers
added a commit
to sarahsimpers/docs-spark-connector
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
to sarahsimpers/docs-spark-connector
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
to sarahsimpers/docs-spark-connector
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
to sarahsimpers/docs-spark-connector
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
that referenced
this pull request
Dec 6, 2024
sarahsimpers
added a commit
that referenced
this pull request
Dec 6, 2024
shuangela
added a commit
that referenced
this pull request
Mar 6, 2025
* DOCSP-29861: Cleanup unused files (#200) (cherry picked from commit 05f3125) * DOCSP-40130 - Note on Sharded Partitioner (#201) Co-authored-by: Nora Reidy <nora.reidy@mongodb.com> (cherry picked from commit e25e13f) * Add Netlify config files via upload * DOCSP-42969 - remove nested admonitions (#204) (#208) (cherry picked from commit b37226e) Co-authored-by: Mike Woofter <108414937+mongoKart@users.noreply.github.com> * DOCSP-44953 TOC Relabel (#214) (#217) * DOCSP-44953 TOC Relabel * edit * Mike's Suggestions * keep configure tls (cherry picked from commit 987747d) Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> * (DOCSP-45749) Denests last phase 1 nested component for spark connector (#220) (#222) * Add dependency installation to vale rule (cherry picked from commit 989f378) * [Spark] Remove autobuilder (#227) (#230) (cherry picked from commit ca7f722) Co-authored-by: Rachel Mackintosh <148898879+rachel-mack@users.noreply.github.com> * DOCSP-46719 Spark Guide 404 (#235) (#239) (cherry picked from commit 671e355) Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> * DOCSP-31186 Add sections for connections (#243) (#248) * add sections for connections * fix vale * fix vale flag * fix ref * fix typos * change steps formatting * change based on mikes feedback * fix vale error * change based on feedback (cherry picked from commit 75df8c4) --------- Co-authored-by: Michael Morisi <michael.morisi@mongodb.com> Co-authored-by: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Co-authored-by: anabellabuckvar <41971124+anabellabuckvar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> Co-authored-by: Sarah Simpers <82042374+sarahsimpers@users.noreply.github.com> Co-authored-by: Rea Rustagi <85902999+rustagir@users.noreply.github.com> Co-authored-by: Rachel Mackintosh <148898879+rachel-mack@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
No content changes other than denesting nested admonition.
The build is clean, but there's a failing check to "check autobuilder for errors" due to autobuilder not being set up-- this is no longer relevant since we use Netlify for builds.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45749
Staging - https://deploy-preview-220--docs-spark-connector.netlify.app/batch-mode/batch-read-config/#overview
Self-Review Checklist