Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed naming of parameter in UpdateTeamRoles #304

Merged
merged 1 commit into from Jul 8, 2022
Merged

Fix: Fixed naming of parameter in UpdateTeamRoles #304

merged 1 commit into from Jul 8, 2022

Conversation

marcoriopel
Copy link
Contributor

@marcoriopel marcoriopel commented Jul 7, 2022 •
edited

Description

The parameter orgID in the UpdateTeamRoles should be groupID as it's modifying team roles in a specific project.

Link to any related issue(s): #303

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@marcoriopel marcoriopel requested a review from a team as a code owner July 7, 2022 20:53
gssbzn
gssbzn approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix
(CLA signed)

@gssbzn gssbzn merged commit 137dd97 into mongodb:master Jul 8, 2022
@gssbzn gssbzn mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoriopel @gssbzn