Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-5547): fix BSON 4.x CI #634

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore(NODE-5547): fix BSON 4.x CI #634

merged 1 commit into from
Sep 28, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Remove nvm and backport node download script from other repos
    • backports init-node-and-npm-env.sh in place of init-nvm
    • backports install-dependencies script.
      • Remove --continue-at - flag, older node versions unable to be downloaded with this set
      • exempt node 6 from upgrading its npm version, npm 3 is unable to install a newer npm version
  • bump @types/node to fix a typescript@next compilation failure
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Fix BSON 4.x setup failures to make it usable for testing

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are tests
  • New TODOs have a related JIRA ticket

@durran durran self-assigned this Sep 28, 2023
@durran durran added the Team Review Needs review from team label Sep 28, 2023
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS old checks unrelated to this change.

@nbbeeken
Copy link
Contributor Author

It is actually related to this change, the @types/node update broke the old TS, but it is unrelated to our package, so we can continue with this, or I can revert that which will make TS-next fail. Pick your poison 😭

@durran
Copy link
Member

durran commented Sep 28, 2023

It is actually related to this change, the @types/node update broke the old TS, but it is unrelated to our package, so we can continue with this, or I can revert that which will make TS-next fail. Pick your poison 😭

@nbbeeken I'd just say revert that one dependency update so everything's green.

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Sep 28, 2023

I can revert that which will make TS-next fail

Everything won't be green if I revert, either way we need a follow-up to fix TS-old or TS-next. I figure we stick with TS-next passing because I think generally folks are on newer TS versions 4.0.2 is quite old now.

https://jira.mongodb.org/browse/NODE-5661

@durran durran merged commit 13d83f5 into 4.x Sep 28, 2023
2 of 4 checks passed
@durran durran deleted the NODE-5547-fix-BSON-4.x-ci branch September 28, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants