Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-5922): replace hardcoded reference to bson#main #647

Merged
merged 2 commits into from
Feb 9, 2024
Merged

test(NODE-5922): replace hardcoded reference to bson#main #647

merged 2 commits into from
Feb 9, 2024

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 9, 2024 •
edited
Loading

Description

What is changing?

Replaced hardcoded reference to bson#main when running pre-benchmark setup for run_granular_benchmarks.js

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-5922

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review February 9, 2024 18:37
@nbbeeken nbbeeken self-assigned this Feb 9, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 9, 2024
@nbbeeken nbbeeken merged commit 22e9b6e into main Feb 9, 2024
4 checks passed
@nbbeeken nbbeeken deleted the NODE-5922 branch February 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @nbbeeken