-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-5830): Update js-bson dependencies #648
Conversation
What's the breakdown of what we decided not to upgrade here? I believe all of these are safe updates, I think eslint/rollup may have dropped certain major Node.js versions but we don't need to compile or lint on anything less than the current LTS. @microsoft/api-extractor ^7.38.4 → ^7.40.1
@rollup/plugin-typescript ^11.1.5 → ^11.1.6
@types/node ^18.19.2 → ^20.11.18
@types/sinon ^10.0.20 → ^17.0.3
@typescript-eslint/eslint-plugin ^5.62.0 → ^7.0.1
@typescript-eslint/parser ^5.62.0 → ^7.0.1
chai ^4.3.10 → ^5.1.0
eslint ^8.55.0 → ^8.56.0
eslint-config-prettier ^8.10.0 → ^9.1.0
eslint-plugin-prettier ^4.2.1 → ^5.1.3
prettier ^2.8.8 → ^3.2.5
rollup ^4.10.0 → ^4.11.0
ts-node ^10.9.1 → ^10.9.2
tsd ^0.28.1 → ^0.30.4
typescript ^5.0.4 → ^5.3.3 Could you remove |
@nbbeeken to respond to your previous comment: The following updates cause errors
In the ticket guidelines is says that "updating TS is NOT a part of this ticket" , which is why I didn't update any of the following:
As for the remaining upgrades, I didn't upgrade eslint or prettier due to a misreading of the ticket, I'll try to update them and update you as I go
|
For the typescript bit, we can still upgrade the TS related tooling and leave typescript on the version it is at now, so the @types/ packages are all fine and the eslint related packages might need to be bumped with eslint |
With the latest commit, all possible upgrades are applied besides ones that error and the typescript only changes. Updates not included:
|
Here's the status when I check locally:
these packages can probably be updated too:
|
Description
Description
Update dev and prod dependencies in the js-bson library to latest safe and compatible versions + ones with minimal code changes.
What is changing?
Upgrades not included:
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Keep dependencies up to date.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript