BelongsToMany sync problem

[jekjek]

I tried to build a testcase to show the problem:

public function testBelongsToManyMultipleSyncFails()
{
    // create test instances
    $user = User::create(array('name' => 'John Doe'));
    $client1 = Client::create(array('name' => 'Pork Pies Ltd.'))->_id;
    $client2 = Client::create(array('name' => 'Buffet Bar Inc.'))->_id;

    // Sync multiple
    $user->clients()->sync(array($client1, $client2));
    $this->assertCount(2, $user->clients);

    // refresh user
    $user = User::where('name', '=', 'John Doe')->first();

    // Sync single
    $user->clients()->sync(array($client1));
    $this->assertCount(1, $user->clients);
}

The second call to sync() triggers the following error:

1) RelationsTest::testBelongsToManyMultipleSyncFails
MongoWriteConcernException: localhost:27017: $in needs an array

/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Collection.php:59
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:679
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:679
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:627
/vagrant/test1/vendor/jenssegers/mongodb/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php:913
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:220
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:220
/vagrant/test1/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:114
/vagrant/test1/vendor/jenssegers/mongodb/tests/RelationsTest.php:490

[jekjek]

To circumvent sync() I use this workaround method in my product repository class:

public function setCategories(Product $model, array $categoryIds)
{
    // remove existing category relations except those that should be assigned anyway
    foreach($model->categories as $category) {

        $cid = $category->getKey();
        if (in_array($cid, $categoryIds)) {
            unset($categoryIds[array_search($cid, $categoryIds)]);
        } else {
            $model->categories()->detach($category);
        }
    }

    // add new category relations
    foreach($categoryIds as $categoryId) {
        $model->categories()->attach($categoryId);
    }
}

[jenssegers]

I added your test to the unit tests and it seems to pass without any errors.

[jekjek]

Ok, interesting.

I installed the latest dev-master version via composer into a fresh environment to try again.

After all package dependencies were installed I started the testsuite with phpunit:

[vagrant@Sandbox_default_1410716971456_18929](ssh) /vagrant/vendor/jenssegers/mongodb # phpunit4
PHPUnit 4.2.4 by Sebastian Bergmann.

Configuration read from /vagrant/vendor/jenssegers/mongodb/phpunit.xml

............F

Time: 611 ms, Memory: 18.50Mb

There was 1 failure:

1) ConnectionTest::testAuth
Failed asserting that exception message 'Failed to connect to: localhost:27017: Authentication failed on database 'unittest' with username 'foo': auth failed' contains 'Failed to connect to: localhost:27017: Authentication failed on database 'unittest' with username 'foo': auth fails'.

It seems pecl-mongo did a minor text change of the exception message. I test with

• php 5.5.16
• pecl-mongo 1.5.4
• mongodb 2.6.4

After I disable or fix the test I run the suite again and now the error shows up:

[vagrant@Sandbox_default_1410716971456_18929](ssh) /vagrant/vendor/jenssegers/mongodb # phpunit4
PHPUnit 4.2.4 by Sebastian Bergmann.

Configuration read from /vagrant/vendor/jenssegers/mongodb/phpunit.xml

...............................................................  63 / 151 ( 41%)
............................................................... 126 / 151 ( 83%)
.E

Time: 2.84 seconds, Memory: 58.50Mb

There was 1 error:

1) RelationsTest::testBelongsToManySync
MongoWriteConcernException: localhost:27017: $in needs an array

/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Collection.php:59
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:679
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:679
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Query/Builder.php:627
/vagrant/vendor/jenssegers/mongodb/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php:913
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:220
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:220
/vagrant/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Relations/BelongsToMany.php:114
/vagrant/vendor/jenssegers/mongodb/tests/RelationsTest.php:276

FAILURES!                              
Tests: 128, Assertions: 580, Errors: 1

[rbruhn]

Just to add a note as this might be related:
I ran into sync issues on newly created records. This is with mysql (expeditions) to mongodb (subjects) models.

public function create($data = array())
 {
        $expedition = $this->model->create($data);
    $expedition->subjects()->sync($data['subject_ids']);

        return $expedition;
}

The above would enter the related expedition_ids as NumberLong() in MongoDb. The model->create method above returns the new record like "$user = User::create(array('name' => 'John Doe'));" does above. Nothing special there.

If I retrieved the newly created record using find() as below, then it worked as expected. The expedition_ids are placed in MongoDb as strings: expedition_ids : ["10"]

Not sure why there is a difference, as I dumped out both $result and $expedition and they are exactly the same. However, this is the way it works.

public function create($data = array())
 {
        $result = $this->model->create($data);
    $expedition = $this->model->find($result->id);
    $expedition->subjects()->sync($data['subject_ids']);

        return $expedition;
}