increment does not create field if missing

[bitinn]

by default mongodb's $inc will create a field when incrementing a field that does not exists, i am not sure if the guard on this line is necessary?

When we try to increment a field that does not exists, the query passes but field was not created.

https://github.com/jenssegers/Laravel-MongoDB/blob/dd899e2c1bee5c4e31fe406499b0523280352032/src/Jenssegers/Mongodb/Query/Builder.php#L404

[jenssegers]

If I remove the line I get the following error message:

MongoCursorException: Cannot apply $inc modifier to non-number

[bitinn]

just wondering if this error comes from any specific test case? if whereNotNull does not guard non-existing value then my problem could be elsewhere.

maybe a testcase can be added to https://github.com/jenssegers/Laravel-MongoDB/blob/727f0e9e346226948a9646b0bc1f5c363333d01e/tests/QueryTest.php#L152 to double check if a missing field will be created when we try to increment?

[jenssegers]

This error occurs when there is a records that has 'null' as attribute value. This records in the test:

array('name' => 'Error', 'age' => null, 'title' => null)

[jenssegers]

I will remove the protection for now.

[jenssegers]

I was actually able to tweak the protection to this:

$this->where(function($query) use ($column)
{
    $query->where($column, 'exists', false);
    $query->orWhereNotNull($column);
});

This protection will included records with non-existing attributes and excluded records with the attribute set to null.