MongoId creation of embedded models edge case #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty string + Laravel coding style of '!'
|
I think this might be fixed by using: Will try that out with your new test. |
jenssegers
added a commit
that referenced
this pull request
Mar 4, 2014
MongoId creation of embedded models edge case
|
This tweak will now only cause |
|
Great ! |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
MongoId creation of embedded models edge case
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen when you get data directly from a form.
Come from #138. I will propose you smaller pull requests in order to make easier reviews, discussions and eventually rejections.