[Ignore] UTCDateTime conversion now includes milliseconds #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divine
reviewed
Feb 15, 2020
divine
reviewed
Feb 15, 2020
divine
reviewed
Feb 15, 2020
divine
reviewed
Feb 15, 2020
divine
reviewed
Feb 15, 2020
divine
suggested changes
Feb 15, 2020
There was a problem hiding this comment.
I think using Laravel Date facade would be better. See explanation here: laravel/framework#25320
It's already available from version 5.8 so it wouldn't break something, otherwise good work!
Co-Authored-By: Divine <48183131+divine@users.noreply.github.com>
Co-Authored-By: Divine <48183131+divine@users.noreply.github.com>
Co-Authored-By: Divine <48183131+divine@users.noreply.github.com>
Co-Authored-By: Divine <48183131+divine@users.noreply.github.com>
Co-Authored-By: Divine <48183131+divine@users.noreply.github.com>
|
@Giacomo92 resolve conflicts please |
|
@Giacomo92 Thank you for getting this up to date! |
Giacomo92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was recreated from #1534
Currently laravel-mongodb strips out the millisecond value of the datetime when retrieving records or querying mongo. This PR fixes the date conversion to include the millisecond part of the date. The PR also saves created_at and updated_at with millisecond precision now.
This PR only works for PHP7 and above as I couldn't find anywhere specifying that PHP5 is supported, and travis is only testing on PHP7.
Co-Authored-By: @Flambe