fix Enums not being cast when calling Model::toArray()
#2522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋,
while testing the migration of a project to Laravel 10, calling
toArray()
on a model caused a warning when attributes are defined to be cast as Enums.(and it didn't work). After diving a bit into the code, I noticed that the previously created
$castValue
was not used when converting the Enum to a string in theaddCastAttributesToArray()
method.I didn't know where to put the Enum for the test, so I just added it to the
models
directory although it felt wrong 😅.The changed order in theuse
statements is due to StyleCI complaining.Let me know if you'd like me to change the Enum location or anything else! 🙏🏻