Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling single model in sync method #2648

Merged
merged 1 commit into from Nov 3, 2023
Merged

Handling single model in sync method #2648

merged 1 commit into from Nov 3, 2023

Conversation

hans-thomas
Copy link
Contributor

@hans-thomas hans-thomas commented Oct 21, 2023 •
edited by GromNaN

Hi, sync and syncWithoutDetaching methods now accept a single model as an argument.
Related issue (fix #2395) and PR (fix #2396).

@hans-thomas hans-thomas marked this pull request as ready for review October 21, 2023 13:48
@hans-thomas
Copy link
Contributor Author

@GromNaN Can you please review this PR?

GromNaN
GromNaN approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

src/Relations/BelongsToMany.php Show resolved Hide resolved
@GromNaN GromNaN added this to the 4.1 milestone Nov 2, 2023
GromNaN
GromNaN approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hans-thomas

@GromNaN GromNaN merged commit 0cdba6a into mongodb:4.1 Nov 3, 2023
13 checks passed
@GromNaN GromNaN mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

syncWithoutDetaching() isn't accepting a single model as an argument
2 participants
@hans-thomas @GromNaN