PHPORM-184 Use fixed key for temporary setting nested field #2962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-184
Fix #2959
The memory leak reported in #2959 is caused by the random temporary key used before setting a nested value. There is a cache in
Illuminate\Suport\Str::studly
that inflate for each random key.Also,
uniqid
is slow and not necessary here. The temporary key can be static as there is not risk of conflict/collision.parent::setAttribute()
is$this->attributes[$key] = $value
;$this->attributes[$key]
is read and wrote in the nested array;$this->attributes[$key]
is unset.There is no possibility of a code acting on this key in the meantime.
Checklist