Add children to Card type #3220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
requested review from
Copilot and
stephl3
and removed request for
a team
🦋 Changeset detectedLatest commit: 0baa570 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Adds explicit children type to the Card component's TypeScript interface for consistency with other LeafyGreen components like Button. The change ensures proper type safety and IntelliSense support for the Card's content prop.
- Adds
children?: React.ReactNodetoInternalCardPropsinterface with JSDoc documentation - Updates README.md to document the
childrenprop in the component API table
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/card/src/Card/types.ts | Adds explicit children prop to Card's TypeScript interface with documentation |
| packages/card/README.md | Documents the children prop in the API reference table |
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
stephl3
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Add explicit
childrentype to Card component. Card is typed usingInferredPolymorphicProps, which is the same as Button, and Button does explicitly specifychildren.Let me know if specific testing would help!
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes