MONGOCRYPT-307 fix compile on VS 2015 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
|
Question: would PHP need this to be released in 1.2.1 now to upgrade? If so, I can tag immediately. If not, I'll wait for the next monthly patch release. |
|
I think you can wait until next month to tag. @alcaeus shouldn't have a problem with bumping the libmongocrypt to a random commit (as we did for libmongoc) in mongodb/mongo-php-driver#1196. |
|
Testing these changes in mongodb/mongo-php-driver#1196. Appveyor build to watch is here: https://ci.appveyor.com/project/jmikola/mongo-php-driver/builds/37663327 |
alcaeus
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a VS 2015 variant to compile to prevent future regressions.