Skip to content

Conversation

kevinAlbs
Copy link
Collaborator

Summary

  • Use prerelease marker when computing previous release version in calc_release_version.py

Background & Motivation

This resolves recent failures of the abi-compliance-check task. The task compares the C driver from the most recent release tag. The most recent release tag is computed here with:

echo $(python ./build/calc_release_version.py --next-minor -p) > VERSION_RELEASED

Before this change, a non-existent tag is output:

% python ./build/calc_release_version.py --next-minor -p
1.22.0

After this change, the 1.22.0-beta1 tag is output:

% python ./build/calc_release_version.py --next-minor -p
1.22.0-beta1

Account for prerelease marker when computing previous release version in
calc_release_version.py
@kevinAlbs kevinAlbs requested a review from rcsanchez97 June 15, 2022 18:22
@kevinAlbs kevinAlbs marked this pull request as ready for review June 15, 2022 18:22
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 232611d into mongodb:master Jun 16, 2022
rcsanchez97 pushed a commit that referenced this pull request Jul 6, 2022
Account for prerelease marker when computing previous release version in
calc_release_version.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants