Skip to content

Conversation

kevinAlbs
Copy link
Collaborator

Resolves CDRIVER-4542 and CDRIVER-4541.

@kevinAlbs kevinAlbs requested a review from eramongodb June 13, 2023 16:53
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion; otherwise, LGTM.

Comment on lines 4 to 7
* Support for macOS 10.14 will be dropped in an upcoming release.
* Support for Ubuntu 14.04 will be dropped in an upcoming release.
* Support for Debian 8.1 will be dropped in an upcoming release.
* The `ENABLE_BSON` configure-time option has been removed. Build scripts that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given updates to supported platforms may become a regular occurrence + we do not(?) consider CMake configuration breaking changes as deserving a major version bump, suggest splitting the first three items from the fourth item into dedicated sections:

Platform Support:

  * Support for MacOS 10.14 ...
  * ...

Build Configuration:

  * The `ENABLE_BSON` CMake option is no longer supported. ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that. Sections have been separated.

we do not(?) consider CMake configuration breaking changes as deserving a major version bump

I think CMake configuration breaking changes do not require a major version bump.

@kevinAlbs kevinAlbs merged commit 0524bd8 into mongodb:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants