Skip to content

Conversation

eramongodb
Copy link
Contributor

A fix to a bug that has not yet been encountered in the C Driver.

If a custom vars={...} argument is given to FetchBuild.call(build_name="abc", vars={...}), e.g. to define additional environment variables, the config generator will fail due to the vars argument being specified multiple times:

TypeError: config_generator.etc.function.Function.default_call() got multiple values for keyword argument 'vars'

This PR uses .update() to ensure if vars is given, that the build_name will correctly be merged into vars instead of triggering a conflict.

@eramongodb eramongodb requested a review from kevinAlbs October 23, 2023 22:05
@eramongodb eramongodb self-assigned this Oct 23, 2023
@eramongodb eramongodb merged commit 99ba0b4 into mongodb:master Oct 24, 2023
@eramongodb eramongodb deleted the cdriver-evg branch October 24, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants