CDRIVER-4795 restore MONGOC_MD_FLAG_ENABLE_ICU
#1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore the enum value
MONGOC_MD_FLAG_ENABLE_ICU
.I suggest reviewing individual commits.
Additional improvements
parse_handshake_cfg.py
is updated to support Python 3.Explicit assignments are added to enum values (e.g.
MONGOC_MD_FLAG_TRACE = 30
instead ofMONGOC_MD_FLAG_TRACE
) to clarify the values are fixed.Background & Motivation
CDRIVER-4680 removed the
MONGOC_MD_FLAG_ENABLE_ICU
from the handshake config.The handshake config is reported in the client metadata sent to the server. Here are examples from the mongod logs (search for "cfg"):
MONGOC_MD_FLAG_ENABLE_ICU
was likely unintentionally removed. Removing shifted the subsequent values down one. This may add difficultly parsing and comparing config values between driver versions.