CDRIVER-4614 Include topology description in error messages #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriandole
force-pushed
the
topology-description
branch
from
5202e26 to
3e5caef
Compare
adriandole
force-pushed
the
topology-description
branch
from
3e5caef to
6a757da
Compare
adriandole
commented
Feb 6, 2024
vector-of-bool
previously requested changes
Apr 4, 2024
kevinAlbs
approved these changes
May 1, 2024
kevinAlbs
dismissed
vector-of-bool’s stale review
I approved latest changes. Want to include in upcoming release.
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
May 1, 2024
…ongodb#1527)" This reverts commit d50f650.
|
I merged to attempt to include in the 1.27.0 release. Windows test tasks started to fail. I re-ran a newly failing task on the previous commit. The task on the previous commit passed. So I expect the failure was introduced by those changes. I reverted the commit. I expect a new PR is needed. Sorry for the noise. |
kevinAlbs
reviewed
May 1, 2024
|
|
||
| done: | ||
| if (error) { | ||
| _mongoc_error_append (error, topology_type->str); |
There was a problem hiding this comment.
If error is non-NULL and an error was not set, I expect this is appending to an uninitialized bson_error_t. This may have been the cause of the Windows task failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRIVERS-2421 requests that timeout messages include the topology description and a list of servers for timeout messages.
The C driver already gathers errors from each server (including the URI). This PR adds a topology description to the end of server selection error messages. It is added last so is omitted if there's no space left in
mongoc_error_t.