CDRIVER-5607 Clean up OID init to avoid a suspicious time_t trunc #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing a clever memcpy of a BE-encoded bunch-of-bits uint32_t, explicitly perform the encoding inline. Avoids a suspicious truncation of time_t to uint32_t, and explains why we are doing it.
kevinAlbs
changed the title
kevinAlbs
approved these changes
Jun 13, 2024
vector-of-bool
added a commit
that referenced
this pull request
Jun 26, 2024
…1643) * Clean up OID init to avoid a suspicious time_t trunc Instead of doing a clever memcpy of a BE-encoded bunch-of-bits uint32_t, explicitly perform the encoding inline. Avoids a suspicious truncation of time_t to uint32_t, and explains why we are doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a clever memcpy of a BE-encoded uint32_t bunch-of-bits, explicitly perform the encoding inline. Avoids a suspicious truncation of time_t to uint32_t, and explains why we are doing it.
This does not directly fix any behavioral issue, but makes the implementation less clever and more explicit for static analysis.
Coverity CID 123525 & CID 123519