CDRIVER-3769 Deprecate unimplemented URI options #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Oct 15, 2024
ghost
commented
- Removes maxidletimems and waitqueuemultiple from the schema of allowed int options
- Adds the suggested unit test from CDRIVER-3769
- Adds an additional similar deprecation unit test for waitqueuemultiple
- Updates other URI unit tests to account for the new expected behavior
ghost
requested a review
from 
kevinAlbs
reviewed
Oct 15, 2024
added 4 commits
October 15, 2024 13:03
From Kevin's review feedback; these tests are a subset of the driver-independent JSON test suite and should not be modified here.
…onnection_uri_cb Following Kevin's suggestion to scan a test_skip_t list in test_connection_uri_cb to skip inapplicable URI tests.
also reformat with jq, some of the indentation was inconsistent.
kevinAlbs
approved these changes
Oct 16, 2024
|
evergreen retry |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.