CDRIVER-6112 fix ownership transfer of mongoc_write_command_t
#2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memcpy does not correctly transfer ownership of the `bson_t` struct. Instead: heap allocate the `bson_t` struct.
eramongodb
approved these changes
Oct 2, 2025
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
Oct 3, 2025
…odb#2132) * add regression test * do not memcpy `bson_t` struct in array * `memcpy` does not correctly transfer ownership of `bson_t`. Instead: heap allocate `bson_t`. * warn against using `bson_t` in `mongoc_array_t`
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
Oct 3, 2025
…odb#2132) * add regression test * do not memcpy `bson_t` struct in array * `memcpy` does not correctly transfer ownership of `bson_t`. Instead: heap allocate `bson_t`. * warn against using `bson_t` in `mongoc_array_t`
kevinAlbs
added a commit
that referenced
this pull request
Oct 6, 2025
… (#2137) * add regression test * do not memcpy `bson_t` struct in array * `memcpy` does not correctly transfer ownership of `bson_t`. Instead: heap allocate `bson_t`. * warn against using `bson_t` in `mongoc_array_t`
kevinAlbs
added a commit
that referenced
this pull request
Oct 6, 2025
… (#2136) * add regression test * do not memcpy `bson_t` struct in array * `memcpy` does not correctly transfer ownership of `bson_t`. Instead: heap allocate `bson_t`. * warn against using `bson_t` in `mongoc_array_t`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change
mongoc_write_command_t::cmd_optsfrombson_ttobson_t*.Tested with this patch: https://spruce.mongodb.com/version/68dd762c5eafa20007be24b2
Background & Motivation
Intended to fix behavior when
mongoc_write_command_tis copied into amongoc_array_t. See comment in CDRIVER-6112 for a more detailed description. This PR proposes a simple fix: changebson_ttobson_t *to simplify ownership transfer.Other instances of
_mongoc_array_initwere checked. No others appear to use an array of a type embeddingbson_t. A comment is added to warn against storingbson_tinmongoc_array_t.