fixed handling of other cursor errors in mongoc_collection_find_indexes #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Was there a specific case that reproduced the bug for you? |
|
It was coincidence. Due to a programming error in our application, multiple threads used the same mongoc_client_t connection concurrently. This caused all kinds of funny errors. |
|
Did you mean to push another commit to this PR? It's not related to your first change. |
|
No I didn't. The second commit was not supposed to go into the first pull request. (maybe a second pull request). I'll try to restore the original pull request... |
|
Ok. I removed the second commit. |
|
Filed the bug: https://jira.mongodb.org/browse/CDRIVER-1420 I've written a test, awaiting my colleagues' review. |
|
Merged in 542c42d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous behavior: function returned freed cursor if an error different from the two hardcoded error cases occurred. caller then ran into a "use-after-free" issue.
new behavior: functions returns a NULL pointer if an error different from the two hardcoded error cases occurred