Skip to content

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Dec 12, 2018

See issue jeroen/mongolite#163

This ensures that leading zero's get included in the ms part of a datetime. Currently dates get printed like this: 1998-11-07T00:00:00. 23Z (note the blank instead of 0).

@kevinAlbs
Copy link
Collaborator

Thanks for the contribution Jeroen. The travis run on your commit failed due to an unrelated failure. Can you rebase this on the tip of master and update? We'll run this through Evergreen and create a C driver ticket.

@kevinAlbs
Copy link
Collaborator

Created https://jira.mongodb.org/browse/CDRIVER-2910 to track this bug. And this will be tested in our BSON corpus tests once mongodb/specifications#438 is merged.

Jeroen, no need to rebase. This is a small change, and after running this through our continuous integration tests I'm confident this is correct. I'm rebasing and merging this. This will be part of the 1.14.0 release.

Thanks for investigating and fixing this!

@kevinAlbs kevinAlbs merged commit 01bbfa8 into mongodb:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants