Skip to content

Conversation

fgalan
Copy link
Contributor

@fgalan fgalan commented Feb 8, 2021

Fixes https://jira.mongodb.org/browse/CDRIVER-3903 changing the only reference that I have found using NO to OFF (doing the other way around, changing all OFF to NO would have involved much more changes).

I hope you find it useful. Feedback welcome.

@bazile-clyde bazile-clyde self-requested a review February 8, 2021 18:29
@bazile-clyde
Copy link
Contributor

LGTM! Feel free to merge.

@kevinAlbs kevinAlbs merged commit 8c202f4 into mongodb:master Feb 9, 2021
@fgalan fgalan deleted the cdriver-3903 branch February 9, 2021 07:50
@fgalan
Copy link
Contributor Author

fgalan commented Feb 9, 2021

Thanks!

The change correctly appears at https://s3.amazonaws.com/mciuploads/mongo-c-driver/docs/libmongoc/latest/init-cleanup.html#deprecated-feature-automatic-initialization-and-cleanup

I understand that when a new version of the driver gets released it will also appear in http://mongoc.org/libmongoc/current/init-cleanup.html#deprecated-feature-automatic-initialization-and-cleanup. Is my understanding correct?

@bazile-clyde
Copy link
Contributor

bazile-clyde commented Feb 9, 2021

Thanks!

The change correctly appears at https://s3.amazonaws.com/mciuploads/mongo-c-driver/docs/libmongoc/latest/init-cleanup.html#deprecated-feature-automatic-initialization-and-cleanup

I understand that when a new version of the driver gets released it will also appear in http://mongoc.org/libmongoc/current/init-cleanup.html#deprecated-feature-automatic-initialization-and-cleanup. Is my understanding correct?

@fgalan That's correct! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants