CDRIVER-4241 SHM counter on mac m1 arm64 implementation. #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
kevinAlbs
requested changes
Dec 12, 2021
There was a problem hiding this comment.
Thank you for the contribution @devnexen! I included questions and suggestions. I filed CDRIVER-4241 for the proposed improvement.
devnexen
force-pushed
the
mongo_sched_getcpu_macm1
branch
from
fda23ed to
e5c9768
Compare
kevinAlbs
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
Thank you again for the contribution @devnexen. Changes LGTM. I am requesting another reviewer. Filed CDRIVER-4240 to add macOS m1 to our test matrix.
eramongodb
approved these changes
Dec 20, 2021
|
Thanks again for the contribution @devnexen. This PR was rebased atop CDRIVER-4240 to test building on a macOS m1 host. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.