CSHARP-4528: Extend Search.Equals to support number and date #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKovacs
requested changes
Mar 21, 2023
| } | ||
|
|
||
| [Fact] | ||
| public void Equals_typed() | ||
| public static object[][] EqualsSupporteddTypesTestData => new[] |
There was a problem hiding this comment.
EqualsSupporteddTypesTestData => EqualsSupportedTypesTestData
(extra "d" in the middle)
| long v => (BsonInt64)v, | ||
| float v => (BsonDouble)v, | ||
| double v => (BsonDouble)v, | ||
| DateTime v => (BsonDateTime)v, |
There was a problem hiding this comment.
Should we support DateTimeOffset too?
There was a problem hiding this comment.
We can. We don't have a direct implicit conversion to BsonDateTime, so not sure how best to account for offset in this case.
Maybe we can consider support for DateTimeOffset both for Equals and Range in a separate ticket?
There was a problem hiding this comment.
Given that BsonDateTime stores the date in UTC, we can do something like this:
DateTimeOffset v => (BsonDateTime)v.UtcDateTime,
We would also need to add tests.
DmitryLukyanov
pushed a commit
that referenced
this pull request
Mar 24, 2023
* CSHARP-4528: Extend Search.Equals to support number and date
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
…#1043) * CSHARP-4528: Extend Search.Equals to support number and date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.