Skip to content

CSHARP-4550: NewExpression and MemberInitExpression behaviour differs #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

sanych-sun
Copy link
Member

Please note this PR is to be followed by another, that will actually remove all code related to new expression translation, by calling init expression translator.

Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several refactoring suggestions discussed offline.

@sanych-sun sanych-sun requested a review from rstam May 23, 2023 16:52
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanych-sun sanych-sun merged commit 7a99e9c into mongodb:master May 23, 2023
@sanych-sun sanych-sun deleted the csharp4550 branch May 23, 2023 22:26
dnickless pushed a commit to dnickless/mongo-csharp-driver that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants