-
Notifications
You must be signed in to change notification settings - Fork 1.3k
v2.21.0 Documentation fixes #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/// <param name="cancellationToken">The cancellation token.</param> | ||
/// <returns> | ||
/// A Task whose result is a cursor. | ||
/// A task whose result is a cursor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task
with a capital T
is a class name.
/// </summary> | ||
public IBsonSerializer<TDerived> DerivedSerializer => _derivedSerializer; | ||
|
||
/// <inheritdoc/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an explicitly implemented interface property and therefore private. Why does it even need <inheritdoc/>
?
/// <param name="name">Name of the index.</param> | ||
/// <param name="definition">The definition.</param> | ||
/// <param name="cancellationToken">The cancellation token.</param> | ||
/// <returns>A task.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true. Returns nothing.
/// <param name="name">Name of the index.</param> | ||
/// <param name="definition">The definition.</param> | ||
/// <param name="cancellationToken">The cancellation token.</param> | ||
/// <returns>A task.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task
with capital T
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.