Skip to content

Conversation

BorisDog
Copy link
Contributor

@BorisDog BorisDog commented Aug 9, 2023

No description provided.

@BorisDog BorisDog requested a review from rstam August 9, 2023 23:57
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>
/// A Task whose result is a cursor.
/// A task whose result is a cursor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task with a capital T is a class name.

/// </summary>
public IBsonSerializer<TDerived> DerivedSerializer => _derivedSerializer;

/// <inheritdoc/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an explicitly implemented interface property and therefore private. Why does it even need <inheritdoc/>?

/// <param name="name">Name of the index.</param>
/// <param name="definition">The definition.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A task.</returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. Returns nothing.

/// <param name="name">Name of the index.</param>
/// <param name="definition">The definition.</param>
/// <param name="cancellationToken">The cancellation token.</param>
/// <returns>A task.</returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task with capital T.

@BorisDog BorisDog requested a review from rstam August 10, 2023 00:26
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BorisDog BorisDog merged commit 5a9c331 into mongodb:master Aug 10, 2023
@BorisDog BorisDog deleted the v2.21.0_docs_fix branch August 10, 2023 00:50
dnickless pushed a commit to dnickless/mongo-csharp-driver that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants