CSHARP-4807: Support serialization of Memory<T> and ReadOnlyMemory<T> #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKovacs
approved these changes
May 23, 2024
| }; | ||
| break; | ||
| default: | ||
| throw new NotSupportedException($"Not supported memory type {typeof(TItem)}. Only primitive numeric types are supported."); |
There was a problem hiding this comment.
Do we want to support decimal, bool, and char as well? nuint and nint seem reasonable to omit.
There was a problem hiding this comment.
Yes we do, ideally we'd support as much primitive types as possible.
It's quick to add, thanks.
| !(__isByte && representation == BsonType.Binary)) | ||
| { | ||
| throw new ArgumentOutOfRangeException(nameof(representation)); | ||
| } |
There was a problem hiding this comment.
We will want to eventually support serialization to BSON vector (BSON Binary subtype 9) for all value types. But that can be done in the context of a new ticket.
There was a problem hiding this comment.
Yup, it will be easy to add additional representation here.
sanych-sun
reviewed
May 24, 2024
| } | ||
| else | ||
| { | ||
| var inner = e.InnerException.Should().BeOfType<TypeInitializationException>().Subject.InnerException; |
There was a problem hiding this comment.
I would prefer to avoid such exceptions. Should we move the failing code from static ctor to some helper method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces custom fast serialization path for
Memory<T>andReadOnlyMemory<T>.Deserializing
Memory/ReadOnlyMemoryis x4.5 times faster than regular arrays on .net8, and x7 faster on .net6.The main performance gain is in the deserialization path, while the main serialization improvements are left out from this PR.
Overflow and truncations checks are not implement yet, as the use-cases this scenario is optimized for exclude such need.
Deserialization performance results:
.net8
.net6