CSHARP-4916: Remove .netstandard 2.0 support #1443
Conversation
BorisDog
requested review from
sanych-sun,
JamesKovacs and
rstam
and removed request for
a team and
sanych-sun
| @@ -84,59 +84,6 @@ public static bool CanTranslate(MethodCallExpression expression) | |||
| return true; | |||
| } | |||
|
|
|||
| #if NETSTANDARD2_0 | |||
There was a problem hiding this comment.
@rstam requesting review just for the LINQ changes. Should be straightforward, but just in case.
BorisDog
requested review from
sanych-sun
and removed request for
JamesKovacs
| @@ -304,7 +299,6 @@ Task("TestCsfleWithMongocryptd") | |||
| RunTests(buildConfig, testProject, filter: "Category=\"CSFLE\"")); | |||
|
|
|||
| Task("TestCsfleWithMongocryptdNet472").IsDependentOn("TestCsfleWithMongocryptd"); | |||
| Task("TestCsfleWithMongocryptdNetStandard20").IsDependentOn("TestCsfleWithMongocryptd"); | |||
| Task("TestCsfleWithMongocryptdNetStandard21").IsDependentOn("TestCsfleWithMongocryptd"); | |||
| Task("TestCsfleWithMongocryptdNet60").IsDependentOn("TestCsfleWithMongocryptd"); | |||
There was a problem hiding this comment.
Also there is reference to netstandard2.0 at line 655 in Setup<BuildConfig> method that might be removed.
|
@BorisDog - there's no description/reasoning for this change here. Was the reason discussed elsewhere (like in JIRA)? |
|
Hi @eerhardt,
|
|
You still support .NET Framework, right? The downside of dropping .NET Standard 2.0 for your consumers is that if they want/need to support both .NET Framework and .NET Core, then they need to multi-target now (i.e. build for both). The benefit of .NET Standard 2.0 is that most consumers don't need to do that and get away with building for a single framework and get a single binary. FWIW, everything we ship that needs to support both still targets .NET Standard 2.0. |
|
Yes, the driver targets |
Interesting. Would you mind sharing these concerns? If you don't want to do this publicly, you can email me immol at microsoft dot com. |
No description provided.