Skip to content

CSHARP-5419: Fix Single Node Replica Set Handling in the Driver #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −3
Closed

CSHARP-5419: Fix Single Node Replica Set Handling in the Driver #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MongoDB.Driver/Core/Clusters/ClusterFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public IClusterInternal CreateCluster()
{
return CreateLoadBalancedCluster(settings);
}
else if (settings.DirectConnection)
else if (settings.DirectConnection || settings.EndPoints.Count == 1)
{
return CreateSingleServerCluster(settings);
}
Expand Down
5 changes: 3 additions & 2 deletions src/MongoDB.Driver/Core/Clusters/SingleServerCluster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal sealed class SingleServerCluster : Cluster
public SingleServerCluster(ClusterSettings settings, IClusterableServerFactory serverFactory, IEventSubscriber eventSubscriber, ILoggerFactory loggerFactory)
: base(settings, serverFactory, eventSubscriber, loggerFactory)
{
Ensure.That(settings.DirectConnection, $"DirectConnection mode is not supported for {nameof(SingleServerCluster)}.");
Ensure.That(!settings.DirectConnection, $"DirectConnection mode is not supported for {nameof(SingleServerCluster)}.");
Ensure.That(settings.SrvMaxHosts == 0, "srvMaxHosts cannot be used with a single server cluster.");
Ensure.IsEqualTo(settings.EndPoints.Count, 1, nameof(settings.EndPoints.Count));

Expand Down Expand Up @@ -121,7 +121,8 @@ private void ServerDescriptionChanged(object sender, ServerDescriptionChangedEve
}

newClusterDescription = newClusterDescription.WithServerDescription(newServerDescription);

if(newClusterDescription.Type == ClusterType.Unknown)
newClusterDescription = newClusterDescription.WithType(newServerDescription.Type.ToClusterType());
var shouldClusterDescriptionChangedEventBePublished = !args.OldServerDescription.SdamEquals(args.NewServerDescription);
UpdateClusterDescription(newClusterDescription, shouldClusterDescriptionChangedEventBePublished);
}
Expand Down