CSHARP-3533/CSHARP-3619: Test that session is unpinned when executing a non-transaction operation. / Unpin sessions after all abortTransaction attempts. #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a non-transaction operation. / Unpin sessions after all abortTransaction attempts.
DmitryLukyanov
commented
May 31, 2021
| _session.CommitTransaction(cancellationToken); | ||
| return OperationResult.Empty(); | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
this catch block should be moved on the lever higher than test level since it's required for any test. Leave this as is since this will require more changes than it's expected for this small PR
BorisDog
reviewed
Jun 1, 2021
tests/MongoDB.Driver.Tests/UnifiedTestOperations/UnifiedAssertSessionUnpinnedOperation.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Driver.Tests/UnifiedTestOperations/UnifiedFindOperation.cs
Outdated
Show resolved
Hide resolved
DmitryLukyanov
added a commit
to DmitryLukyanov/mongo-csharp-driver
that referenced
this pull request
Jun 23, 2021
… a non-transaction operation. / Unpin sessions after all abortTransaction attempts. (mongodb#540)
DmitryLukyanov
added a commit
to DmitryLukyanov/mongo-csharp-driver
that referenced
this pull request
Jun 29, 2021
CSHARP-3669: Code review. CSHARP-3676: SRV support for load balancer mode. CSHARP-3533/CSHARP-3619: Test that session is unpinned when executing a non-transaction operation. / Unpin sessions after all abortTransaction attempts. (mongodb#540) CSHARP-3673: Update connection pinning logic for LB mode. CSHARP-3675: Sessions should not be expired in LB mode. CSHARP-3672: LB support integration testing. CSHARP-3673: Better wait queue timeout errors for load balanced clusters. CSHARP-3670: Handling serviceId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 tickets: