CSHARP-3427: Fix test. #541
Conversation
DmitryLukyanov
force-pushed
the
csharp3427_fix
branch
from
664a42c to
1a7e502
Compare
done |
|
|
||
| // the default assembly-based logic. Ideally expectedRootTestFolder should be mongo-csharp-driver, | ||
| // but since it's not mocked logic, it limits us where we can run our tests from. Avoid it by | ||
| // making a test assertation less strict | ||
| [InlineData(null, "")] |
There was a problem hiding this comment.
Consider using the suggested refactoring: MikalaiMazurenka@bd94d56
There was a problem hiding this comment.
the validation and asserting steps here are the same, the only difference is input data, the ideal solution here is ClassData but it looks like overkill for this case, a simple if solves everything we need to. So I would leave this as is
There was a problem hiding this comment.
Alright, then could you remove the extra blank line and consider changing the 3 line comment to
| // the default assembly-based logic. Ideally expectedRootTestFolder should be mongo-csharp-driver, | |
| // but since it's not mocked logic, it limits us where we can run our tests from. Avoid it by | |
| // making a test assertation less strict | |
| [InlineData(null, "")] | |
| [InlineData(null, "")] // This case validates only the ending of the path with GetBaseAssemblyUri being used |
There was a problem hiding this comment.
I wanted to explain why this change is necessary since it's kind of not obvious exception, you comment doesn't provide this info, however I don't mind about changing messages, it will be good to hear @JamesKovacs opinion here also
CSHARP-3427: Relax assertion of native library loader test.
Evergreen: https://evergreen.mongodb.com/version/60b6a2611e2d173aca1bb5ae