CSHARP-3977: Refactor GroupForLinq3 to return an explicit type. #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
requested changes
Nov 23, 2021
| /// </summary> | ||
| public PipelineStageDefinition<IGrouping<TValue, TInput>, TOutput> ProjectStage { get; } | ||
|
|
||
| internal GroupForLinq3Result(PipelineStageDefinition<TInput, IGrouping<TValue, TInput>> groupStage, PipelineStageDefinition<IGrouping<TValue, TInput>, TOutput> projectStage) |
There was a problem hiding this comment.
constructors before properties
| /// <summary> | ||
| /// The resulting group stage. | ||
| /// </summary> | ||
| public PipelineStageDefinition<TInput, IGrouping<TValue, TInput>> GroupStage { get; } |
There was a problem hiding this comment.
Blank line between properties when using XML doc comments.
| ProjectStage = projectStage; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add the following Deconstruct methods so that we can deconstruct it just like we can a Tuple:
/// <summary>
/// Deconstructs this class into its components.
/// </summary>
/// <param name="groupStage">The group stage.</param>
/// <param name="projectStage">The project stage.</param>
public void Deconstruct(
out PipelineStageDefinition<TInput, IGrouping<TValue, TInput>> groupStage,
out PipelineStageDefinition<IGrouping<TValue, TInput>, TOutput> projectStage)
{
groupStage = GroupStage;
projectStage = ProjectStage;
}
| var (groupStage, projectStage) = PipelineStageDefinitionBuilder.GroupForLinq3(id, group); | ||
| return aggregate.AppendStage(groupStage).AppendStage(projectStage); | ||
| var stages = PipelineStageDefinitionBuilder.GroupForLinq3(id, group); | ||
| return aggregate.AppendStage(stages.GroupStage).AppendStage(stages.ProjectStage); |
| var (groupStage, projectStage) = PipelineStageDefinitionBuilder.GroupForLinq3(id, group, translationOptions); | ||
| return pipeline.AppendStage(groupStage).AppendStage(projectStage); | ||
| var stages = PipelineStageDefinitionBuilder.GroupForLinq3(id, group, translationOptions); | ||
| return pipeline.AppendStage(stages.GroupStage).AppendStage(stages.ProjectStage); |
| @@ -234,20 +234,20 @@ public void PipelineStageDefinitionBuilder_Group_with_expressions_should_throw_w | |||
| [Fact] | |||
| public void PipelineStageDefinitionBuilder_GroupForLinq3_with_expressions_should_throw_with_LINQ2() | |||
| { | |||
| var (groupStageDefinition, projectStageDefinition) = PipelineStageDefinitionBuilder.GroupForLinq3((BsonDocument x) => 1, x => new { Count = x.Count() }); | |||
| var stages = PipelineStageDefinitionBuilder.GroupForLinq3((BsonDocument x) => 1, x => new { Count = x.Count() }); | |||
There was a problem hiding this comment.
Revert this change and all others in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to a better name for the return type. I debated whether to make it a nested type inside
PipelineStageDefinitionBuilderbut decided against it. I'd be willing to reconsider that decision if you think it's a better choice.