CSHARP-4031: Update load balancer tests to support dedicated load balancer port. #752
Conversation
| if (Serverless) | ||
| switch (clusterType) | ||
| { | ||
| case ClusterType.LoadBalanced: |
There was a problem hiding this comment.
LoadBalanced can use the same workaround as we used for serverless
| @@ -1,10 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
We can also update /initial-dns-seedlist-discovery/tests/README.rst to the latest.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "description": "cursors are correctly pinned to connections for load-balanced clusters", | |||
| "schemaVersion": "1.3", | |||
| "schemaVersion": "1.4", | |||
There was a problem hiding this comment.
These changes are from https://jira.mongodb.org/browse/DRIVERS-1767. Should this be done in this ticket?
There was a problem hiding this comment.
i don't think so since DRIVERS-1767 doesn't trigger creating CSHARP ticket due to low priority.
Also, in general we usually just take the latest spec changes if the extra changes don't make any test fail and don't require additional step in the initial ticket. Also it should not make working with other affected tickets harder, first of all with git diff. I think it's not 100% rule for all cases, but I think it's true at the very least for such simple cases
…ancer port. (mongodb#752) CSHARP-4031: Update load balancer tests to support dedicated load balancer port.
No description provided.