Skip to content

CSHARP-4111: Incorrect & outdated CSFLE statements in C# docs. #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2022

Conversation

DmitryLukyanov
Copy link
Contributor

No description provided.

Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question and fix for spelling error.

## mongocryptd configuration

Client-side field level encryption requires the `mongocryptd` daemon / process
Client-side field level automatic encryption requires the `mongocryptd` daemon / process
to be running. If `mongocryptd` isn't running, the driver will atempt to spawn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atempt => attempt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

## mongocryptd configuration

Client-side field level encryption requires the `mongocryptd` daemon / process
Client-side field level automatic encryption requires the `mongocryptd` daemon / process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a separate ticket for documenting the shared library instead of mongocryptd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have only this https://jira.mongodb.org/browse/CSHARP-4164. The doc changes I reviewed previous days were also only about FLE1, but I assume that next step will be adding the same documentation for FLE2

Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitryLukyanov DmitryLukyanov merged commit 076d425 into mongodb:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants