-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4111: Incorrect & outdated CSFLE statements in C# docs. #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question and fix for spelling error.
## mongocryptd configuration | ||
|
||
Client-side field level encryption requires the `mongocryptd` daemon / process | ||
Client-side field level automatic encryption requires the `mongocryptd` daemon / process | ||
to be running. If `mongocryptd` isn't running, the driver will atempt to spawn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atempt => attempt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
## mongocryptd configuration | ||
|
||
Client-side field level encryption requires the `mongocryptd` daemon / process | ||
Client-side field level automatic encryption requires the `mongocryptd` daemon / process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a separate ticket for documenting the shared library instead of mongocryptd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have only this https://jira.mongodb.org/browse/CSHARP-4164. The doc changes I reviewed previous days were also only about FLE1, but I assume that next step will be adding the same documentation for FLE2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.