Skip to content

CSHARP-3191: driver tries to run getLastError on mongocryptd that does not exists. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2022
Merged

CSHARP-3191: driver tries to run getLastError on mongocryptd that does not exists. #827

merged 2 commits into from
Jun 22, 2022

Conversation

DmitryLukyanov
Copy link
Contributor

The mongocryptd's hello response:

    MongoDB Enterprise > db.isMaster()
    {
            "ismaster" : true,
            "iscryptd" : true,
            "maxBsonObjectSize" : 16777216,
            "maxMessageSizeBytes" : 48000000,
            "localTime" : ISODate("2022-06-22T01:27:36.854Z"),
            "maxWireVersion" : 17,
            "minWireVersion" : 0,
            "ok" : 1
    }

BorisDog
BorisDog approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/MongoDB.Driver.Core.Tests/Core/Connections/HelloResultTests.cs Outdated
};

var subject = new HelloResult(helloResultDocument);
subject.IsMongocryptd.Should().Be(isMongocryptd.GetValueOrDefault(defaultValue: false));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in such simple cases named parameters can be omitted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer explicit definitions, but I don't mind to change it. Done

@DmitryLukyanov DmitryLukyanov merged commit 36e6228 into mongodb:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisDog BorisDog BorisDog approved these changes

@JamesKovacs JamesKovacs Awaiting requested review from JamesKovacs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryLukyanov @BorisDog