Skip to content

added serialization options convention. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2012
Merged

added serialization options convention. #84

merged 1 commit into from
Feb 18, 2012

Conversation

craiggwilson
Copy link
Contributor

No description provided.

@rstam
Copy link
Contributor

rstam commented Feb 18, 2012

The changes look good.

Why did git think some files were 100% replaced? Is there something going
on with line endings or tabs instead of white spaces?

On Sat, Feb 18, 2012 at 10:45 AM, Craig Wilson <
reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull https://github.com/craiggwilson/mongo-csharp-driverserialization_convention

Or you can view, comment on it, or merge it online at:

#84

-- Commit Summary --

  • added serialization options convention.

-- File Changes --

M Bson/Bson.csproj (477)
M Bson/Serialization/BsonClassMap.cs (6)
M Bson/Serialization/Conventions/ConventionProfile.cs (27)
A Bson/Serialization/Conventions/SerializationOptionsConventions.cs (97)
M BsonUnitTests/BsonUnitTests.csproj (407)
A BsonUnitTests/DefaultSerializer/BsonClassMapAutoMappingTests.cs (91)
M BsonUnitTests/DefaultSerializer/BsonClassMapTests.cs (612)

-- Patch Links --

https://github.com/mongodb/mongo-csharp-driver/pull/84.patch
https://github.com/mongodb/mongo-csharp-driver/pull/84.diff

Reply to this email directly or view it on GitHub:
#84

@craiggwilson
Copy link
Contributor Author

idk, I didn't look. That might be the case...

On Sat, Feb 18, 2012 at 10:58 AM, Robert Stam <
reply@reply.github.com

wrote:

The changes look good.

Why did git think some files were 100% replaced? Is there something going
on with line endings or tabs instead of white spaces?

On Sat, Feb 18, 2012 at 10:45 AM, Craig Wilson <
reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull
https://github.com/craiggwilson/mongo-csharp-driverserialization_convention

Or you can view, comment on it, or merge it online at:

#84

-- Commit Summary --

  • added serialization options convention.

-- File Changes --

M Bson/Bson.csproj (477)
M Bson/Serialization/BsonClassMap.cs (6)
M Bson/Serialization/Conventions/ConventionProfile.cs (27)
A Bson/Serialization/Conventions/SerializationOptionsConventions.cs (97)
M BsonUnitTests/BsonUnitTests.csproj (407)
A BsonUnitTests/DefaultSerializer/BsonClassMapAutoMappingTests.cs (91)
M BsonUnitTests/DefaultSerializer/BsonClassMapTests.cs (612)

-- Patch Links --

https://github.com/mongodb/mongo-csharp-driver/pull/84.patch
https://github.com/mongodb/mongo-csharp-driver/pull/84.diff

Reply to this email directly or view it on GitHub:
#84

Reply to this email directly or view it on GitHub:
#84 (comment)

@rstam
Copy link
Contributor

rstam commented Feb 18, 2012

It does seem to be some non standard line endings (I'm looking at the diffs
with BeyondCompare).

No worries, Visual Studio offered to standardize the line endings when I
opened the file.

I'm in the process of merging but will have to run out at any minute, so I
probably won't finish until tonight.

Thanks for working on this!

On Sat, Feb 18, 2012 at 11:09 AM, Craig Wilson <
reply@reply.github.com

wrote:

idk, I didn't look. That might be the case...

On Sat, Feb 18, 2012 at 10:58 AM, Robert Stam <
reply@reply.github.com

wrote:

The changes look good.

Why did git think some files were 100% replaced? Is there something going
on with line endings or tabs instead of white spaces?

On Sat, Feb 18, 2012 at 10:45 AM, Craig Wilson <
reply@reply.github.com

wrote:

You can merge this Pull Request by running:

git pull

https://github.com/craiggwilson/mongo-csharp-driverserialization_convention

Or you can view, comment on it, or merge it online at:

#84

-- Commit Summary --

  • added serialization options convention.

-- File Changes --

M Bson/Bson.csproj (477)
M Bson/Serialization/BsonClassMap.cs (6)
M Bson/Serialization/Conventions/ConventionProfile.cs (27)
A Bson/Serialization/Conventions/SerializationOptionsConventions.cs
(97)
M BsonUnitTests/BsonUnitTests.csproj (407)
A BsonUnitTests/DefaultSerializer/BsonClassMapAutoMappingTests.cs (91)
M BsonUnitTests/DefaultSerializer/BsonClassMapTests.cs (612)

-- Patch Links --

https://github.com/mongodb/mongo-csharp-driver/pull/84.patch
https://github.com/mongodb/mongo-csharp-driver/pull/84.diff

Reply to this email directly or view it on GitHub:
#84

Reply to this email directly or view it on GitHub:

#84 (comment)

Reply to this email directly or view it on GitHub:
#84 (comment)

@rstam rstam merged commit 20e9daf into mongodb:master Feb 18, 2012
@rstam
Copy link
Contributor

rstam commented May 29, 2012

Do you get these emails when a pull request is made?

Want to take a look?

---------- Forwarded message ----------
From: Ray O'Neill <
reply@reply.github.com

Date: Sat, May 26, 2012 at 12:15 AM
Subject: [mongo-csharp-driver] Standalone ToLower/ToUpper Support (Take 2)
(#110)
To: Robert Stam robert@robertstam.org

Only modified 2 files, PredicateTranslator, and SelectQueryTests. Not sure
why the others are included in this request- not a git expert.

You can merge this Pull Request by running:

git pull https://github.com/ray2k/mongo-csharp-driver master

Or you can view, comment on it, or merge it online at:

#110

-- Commit Summary --

  • ToLower/ToUpper take 2

-- File Changes --

M Bson/Serialization/Conventions/ConventionProfile.cs (594)
M Bson/Serialization/Conventions/SerializationOptionsConventions.cs (202)
M BsonUnitTests/DefaultSerializer/BsonClassMapAutoMappingTests.cs (178)
M Driver/Linq/Translators/PredicateTranslator.cs (59)
M DriverUnitTests/Linq/SelectQueryTests.cs (284)

-- Patch Links --

https://github.com/mongodb/mongo-csharp-driver/pull/110.patch
https://github.com/mongodb/mongo-csharp-driver/pull/110.diff

Reply to this email directly or view it on GitHub:
#110

@craiggwilson
Copy link
Contributor Author

Yes, this is in response to my request to him to rebase his earlier
pull request. I'll take care of it.

On Tue, May 29, 2012 at 2:37 PM, Robert Stam
reply@reply.github.com
wrote:

Do you get these emails when a pull request is made?

Want to take a look?

---------- Forwarded message ----------
From: Ray O'Neill <
reply@reply.github.com

Date: Sat, May 26, 2012 at 12:15 AM
Subject: [mongo-csharp-driver] Standalone ToLower/ToUpper Support (Take 2)
(#110)
To: Robert Stam robert@robertstam.org

Only modified 2 files, PredicateTranslator, and SelectQueryTests. Not sure
why the others are included in this request- not a git expert.

You can merge this Pull Request by running:

 git pull https://github.com/ray2k/mongo-csharp-driver master

Or you can view, comment on it, or merge it online at:

 #110

-- Commit Summary --

  • ToLower/ToUpper take 2

-- File Changes --

M Bson/Serialization/Conventions/ConventionProfile.cs (594)
M Bson/Serialization/Conventions/SerializationOptionsConventions.cs (202)
M BsonUnitTests/DefaultSerializer/BsonClassMapAutoMappingTests.cs (178)
M Driver/Linq/Translators/PredicateTranslator.cs (59)
M DriverUnitTests/Linq/SelectQueryTests.cs (284)

-- Patch Links --

 https://github.com/mongodb/mongo-csharp-driver/pull/110.patch
 https://github.com/mongodb/mongo-csharp-driver/pull/110.diff

Reply to this email directly or view it on GitHub:
#110

Reply to this email directly or view it on GitHub:
#84 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craiggwilson @rstam