Skip to content

Conversation

buvinghausen
Copy link

The SourceLink setup is not done correctly. I've gone ahead and hoisted all the common properties from the various .csproj files in your src folder to use the Directory.Build.props file and set it up set the required fags on your next release.

You can verify the setup is incorrect at NuGet Package Explorer

Since I cannot tell what CI system you are using I have it set the ContinuousIntegrationBuild setting when it is built in release mode. Clearly we can tweak that setting to what you need.

@BorisDog
Copy link
Contributor

Thanks @buvinghausen for noticing this and your PR. Is there anything else incorrect in the SourceLink setup, besides untracked sources warning? If so please open Jira tickets for any other issue.

Untracked sources fix is tracked in CSHARP-3994. I've linked this PR to that ticket, please follow it of any further updates.

@buvinghausen
Copy link
Author

@BorisDog yes you need to set the ContinuousIntegrationBuild flag as well. I have it set to conditionally only get set on release as I assume you build in release mode as part of your publish to nuget process. I couldn't tell what CI server/service you use.

@DmitryLukyanov
Copy link
Contributor

DmitryLukyanov commented Oct 25, 2022

@BorisDog yes you need to set the ContinuousIntegrationBuild flag as well. I have it set to conditionally only get set on release as I assume you build in release mode as part of your publish to nuget process. I couldn't tell what CI server/service you use.

Hey @buvinghausen , thanks for this catch. We already configure this option in our build scripts here, but apparently something is broken here. We will investigate this issue in this ticket https://jira.mongodb.org/browse/CSHARP-4384

@DmitryLukyanov
Copy link
Contributor

I've also created a ticket to consider adding build.props to the solution https://jira.mongodb.org/browse/CSHARP-4385. Please follow to that ticket for further discussions

@sanych-sun sanych-sun self-requested a review February 9, 2024 01:02
@sanych-sun
Copy link
Member

Thank you for your contribution. I'll close this Pull Request as already done. Please feel free to reopen it if there are some additional work or help required.

@sanych-sun sanych-sun closed this Feb 20, 2024
@buvinghausen
Copy link
Author

@sanych-sun not sure why you closed this after two years you STILL don't have this repository appropriately setup for Source Link

https://nuget.info/packages/MongoDB.Driver/2.23.2

image

Here's an example of an appropriately setup package
https://nuget.info/packages/SequentialGuid/4.0.4

image

@sanych-sun
Copy link
Member

I've closed this PR because the proposed changes was mostly implemented by using Directory.Build.props file in scope of CSHARP-4385.

The issue with untracked sources you have mentioned was separated into additional Jira ticket and was not sorted yet:
CSHARP-3994. I haven't approach this problem yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants