Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Skip tests depending on __pclass encoding order for PHPC #31

Closed
wants to merge 1 commit into from
Closed

Skip tests depending on __pclass encoding order for PHPC #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/bson-serialize-object-persistable-001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
BSON serialization: PHP persistable object
--SKIPIF--
<?php if (!defined("HHVM_VERSION_ID")) exit("skip PHPC encodes __pclass first"); ?>
--FILE--
<?php
class LiquidClass implements MongoDB\BSON\Persistable
Expand Down
2 changes: 2 additions & 0 deletions tests/bson-serialize-object-persistable-002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
BSON serialization: PHP persistable object write overwritten __pclass
--SKIPIF--
<?php if (!defined("HHVM_VERSION_ID")) exit("skip PHPC encodes __pclass first"); ?>
--FILE--
<?php
class LiquidClass implements MongoDB\BSON\Persistable
Expand Down
2 changes: 2 additions & 0 deletions tests/bson-serialize-object-serializable-006.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
BSON serialization: PHP serializable object: examples from spec
--SKIPIF--
<?php if (!defined("HHVM_VERSION_ID")) exit("skip PHPC encodes __pclass first"); ?>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, the protected/private tests in this file should pass with mongodb/mongo-php-driver#118; however, __pclass is also here so we need to skip the entire file.

--FILE--
<?php
class MyClass
Expand Down