Support native query without parameters #128
Conversation
stIncMale
force-pushed
the
HIBERNATE-60
branch
from
6572fbb to
72dd7e0
Compare
|
|
||
| public static final ObjectIdJdbcType INSTANCE = new ObjectIdJdbcType(); | ||
| public static final MqlType MQL_TYPE = MqlType.OBJECT_ID; | ||
| public static final SQLType MQL_TYPE = MqlType.OBJECT_ID; |
There was a problem hiding this comment.
I made MqlType package-access, as it does not need to be public.
There was a problem hiding this comment.
TODO @stIncMale Rename the field to SQL_TYPE.
| typeContributions.contributeJavaType(ObjectIdJavaType.INSTANCE); | ||
| typeContributions.contributeJdbcType(ObjectIdJdbcType.INSTANCE); | ||
| var objectIdTypeCode = MqlType.OBJECT_ID.getVendorTypeNumber(); | ||
| var objectIdTypeCode = ObjectIdJdbcType.MQL_TYPE.getVendorTypeNumber(); |
There was a problem hiding this comment.
MqlType was made package-access. Furthermore, ObjectIdJdbcType.MQL_TYPE explicitly points to our implementation of the JdbcType for ObjectId, which improves readability.
| throw exceptionDomainTypeUnsupportedOrMustBeExplicit(value, domainType); | ||
| } | ||
|
|
||
| public static @Nullable Object toDomainValue(BsonValue value) throws SQLFeatureNotSupportedException { |
There was a problem hiding this comment.
This PR only needed this new method. However, I also wanted to stop using Object.class to represent "unknown domain type", which caused the rest of the changes.
stIncMale
force-pushed
the
HIBERNATE-60
branch
from
72dd7e0 to
510ae1f
Compare
| @Table(name = COLLECTION_NAME) | ||
| @SqlResultSetMapping( | ||
| name = ItemWithFlattenedValue.MAPPING_FOR_FLATTENED_VALUE, | ||
| columns = { |
There was a problem hiding this comment.
I tried also using SqlResultSetMapping.classes, but I don't think Hibernate ORM implements that one correctly: instead of trying to find the corresponding constructor, it uses the no-argument constructor and then tries to populate the object, searching for the field/property based on the ColumnResult.name, which represents the column name, and does not have to match the name of a field/property.
stIncMale
force-pushed
the
HIBERNATE-60
branch
2 times, most recently
from
02c39c7 to
51b953e
Compare
stIncMale
force-pushed
the
HIBERNATE-60
branch
from
51b953e to
6fb9e8c
Compare
| @Table(name = COLLECTION_NAME) | ||
| static class ItemWithArrayAndCollectionValues { | ||
| @SqlResultSetMapping( | ||
| name = ItemWithArrayAndCollectionValues.MAPPING_FOR_ITEM, |
There was a problem hiding this comment.
TODO @stIncMale File a ticket about creating a static helper method project(ItemWithArrayAndCollectionValues.class, ItemWithArrayAndCollectionValues.MAPPING_FOR_ITEM) that constructs the $project stage.
| * queries</a>, {@link QueryProducer#createNativeQuery(String, Class)}. | ||
| */ | ||
| @Test | ||
| void testScalar() { |
There was a problem hiding this comment.
TODO @stIncMale
Add
() -> {
var mql = mql(COLLECTION_NAME, List.of(match(eq(itemWithNestedValue.id)), project(include("nested"))));
assertEq(
itemWithNestedValue.nested,
session.createNativeQuery(mql, StructAggregateEmbeddableIntegrationTests.Plural.class).getSingleResult());
}
HIBERNATE-60