Skip to content

Fix OIDC tests. #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2025
Merged

Fix OIDC tests. #1753

merged 10 commits into from
Jul 17, 2025

Conversation

vbabanin
Copy link
Member

@vbabanin
Fix OIDC tests.
adece27 
JAVA-5337
@vbabanin vbabanin self-assigned this Jun 25, 2025
@vbabanin vbabanin requested a review from a team as a code owner June 25, 2025 21:07
@vbabanin vbabanin requested review from stIncMale and removed request for a team June 25, 2025 21:07
stIncMale
stIncMale requested changes Jun 26, 2025
View reviewed changes
Copy link
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took some time to figure out why the only PR for https://jira.mongodb.org/browse/JAVA-5337 is the current one, where just a few test code lines are changed. Turned out that the commit containing the actual changes 68d5421 was merged with an incorrect description linking to https://jira.mongodb.org/browse/JAVA-5357. This will make the ticket undiscoverable in the future.

vbabanin and others added 2 commits June 26, 2025 15:50
@vbabanin @stIncMale
Update driver-sync/src/test/functional/com/mongodb/internal/connectio…
342a831 
…n/OidcAuthenticationProseTests.java

Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
@vbabanin @stIncMale
Update driver-sync/src/test/functional/com/mongodb/internal/connectio…
233b66b 
…n/OidcAuthenticationProseTests.java

Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
@vbabanin vbabanin requested a review from stIncMale June 26, 2025 22:52
@vbabanin
Copy link
Member Author

It took some time to figure out why the only PR for https://jira.mongodb.org/browse/JAVA-5337 is the current one, where just a few test code lines are changed. Turned out that the commit containing the actual changes 68d5421 was merged with an incorrect description linking to https://jira.mongodb.org/browse/JAVA-5357. This will make the ticket undiscoverable in the future.

I’ve added cross-references in both tickets and updated the PR comments for traceability. I’ll also check what can be done to unlink the incorrect PR association from the ticket.

@vbabanin vbabanin requested a review from rozza June 30, 2025 15:31
@vbabanin vbabanin merged commit 0a110dc into mongodb:main Jul 17, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

@stIncMale stIncMale Awaiting requested review from stIncMale

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbabanin @rozza @stIncMale