Skip to content

JAVA-3134 Point GitHub links in docs to correct release branches #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

IanWhalen
Copy link

First pass, @rozza - let me know if this catches what you were thinking of. Your note about the /driver folder becoming /driver-sync doesn't seem to have any impact on the docs?

Also note that this initial commit doesn't update the "Edit this doc" pointers like:
https://github.com/mongodb/mongo-java-driver/blob/gh-pages/3.9/bson/codecs/index.html#L253

Let me know if you'd like those updated too.

Assuming this PR is OK, I'll follow it up with a series of PRs across all of the release branches to fix the QuickTour links.

@IanWhalen IanWhalen self-assigned this Jan 13, 2019
@IanWhalen IanWhalen requested a review from rozza January 13, 2019 16:48
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Good catch on the edit this doc links - they should also be updated.

@IanWhalen
Copy link
Author

Additional changes made - note that this has now caught the 'edit this page' links as well as a variety of links to QuickTour*.java files. I've tried a sampling of both kinds of links from pre and post 3.7.x and both seem to work.

I also just tried grepping the entire tree for /master/ and the only remaining links referencing that branch look to be referencing others repos.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit: 👍

@IanWhalen IanWhalen merged commit 5afe0bb into mongodb:gh-pages Jan 15, 2019
@IanWhalen IanWhalen deleted the gh-pages branch January 15, 2019 14:08
@IanWhalen IanWhalen restored the gh-pages branch January 15, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants