Use BSON round-trip to normalize pipelines for comparison #13
Conversation
GromNaN
force-pushed
the
bson-normalize-test
branch
from
5f6cbd0 to
2b8a6ae
Compare
tests/Builder/BuilderEncoderTest.php
Outdated
| self::objectify($expected); | ||
| // Normalize with BSON round-trip | ||
| // BSON Documents doesn't support top-level arrays. | ||
| $actual = Document::fromPHP(['root' => $actual])->toRelaxedExtendedJSON(); |
There was a problem hiding this comment.
Any reason not to use toCanonicalExtendedJSON()?
There was a problem hiding this comment.
I must admit that I'm very confused between the 2 methods. toCanonicalExtendedJSON() is the correct one to use.
There was a problem hiding this comment.
Generally, you should stick to canonical mode. Relaxed mode is fine for concise output (e.g. debugging), but canonical is necessary to ensure accurate type comparisons.
|
|
||
| // BSON Documents doesn't support top-level arrays. | ||
| $expected = toPHP(fromJSON('{"root":' . $expectedJson . '}'))->root; | ||
| $expected = '{"pipeline":' . $expectedJson . '}'; |
There was a problem hiding this comment.
I realize this is outside of the PR diff, but when is a BackedEnum used to store the expected JSON string?
There was a problem hiding this comment.
Maybe @GromNaN has some new fancy ENUM ideas? 😆 🙈
There was a problem hiding this comment.
It was introduced in #6 to generate test pipelines from config Yaml.
GromNaN
force-pushed
the
bson-normalize-test
branch
from
2b8a6ae to
e44f7d0
Compare
| Stage::match( | ||
| // sku: \MongoDB\Builder\Query::regex('789$', ''), | ||
| sku: new Regex('789$', ''), | ||
| sku: Query::regex('789$', ''), |
There was a problem hiding this comment.
Looks like comparing JSON allows to fix this issue: #6 (comment)
Use the driver feature to normalize the aggregation pipeline in PHP.
Diffs are easier to read when using JSON comparison.
Part of PHPLIB-1291
Related to #8